fix: resolve cross-package test failures and type errors - #88
Open
stooit wants to merge 1 commit into
Open
Conversation
- api.ts: import/use useSearchDebounce (renamed from useThrottle) from @e2e/utils - Button: forward aria-label so icon-only buttons have an accessible name - DataTable: use functional state updater to fix stale-closure sort direction bug - date.ts: use correct locale/format so day 1 is not confused with month 1 - tsconfig: add bun-types to types so bun:test resolves in test files All 13 tests pass; tsc --noEmit is clean. No test files or dependencies changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and eliminates all type errors across the monorepo. After the fixes,
bun run testreports 13 pass / 0 fail andtsc --noEmitexits 0.Tests are run via the
bun run testpackage script (which sets up the happy-dom preload); barebun testskips that preload and produces spuriousdocument is not definederrors.Bugs fixed
apps/web/src/lib/api.ts@e2e/utils; import/useuseSearchDebounceinstead of the removeduseThrottle.packages/ui/src/components/Button/Button.tsxaria-labelso icon-only buttons expose an accessible name (a11y test).packages/ui/src/components/DataTable/DataTable.tsxpackages/utils/src/format/date.tstsconfig.jsonbun-typestocompilerOptions.typessobun:testresolves in test files (config-only;bun-typesalready a devDependency).Verification
bun run test→ 13 pass, 0 failtsc --noEmit→ exit 0, no errorsConstraints honoured
bun-typeswas already present).